Fix chat history filter dropping repeated user messages#598
Open
au-sf wants to merge 1 commit into
Open
Conversation
…tory The filter was meant to skip the message just pushed by the caller, but it matches by content, so a repeated message like "tell me more" also removes the previous turn from the history sent to the backend.
dosubot
Bot
added
the
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hit this while testing chat in step 5. If you send the same short reply twice (e.g. "tell me more") the filter at Step5Interaction.vue:687 also drops the earlier matching message, so the backend gets a chat_history with consecutive assistant messages and no immediately-preceding user turn.
Repro:
Same shape of bug at line 723 in sendToAgent.